-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated. GeneticEngine to latest version (2024 competition) #189
Conversation
Hi @alcides, It seems you’re using Python 3.12, which isn’t compatible with the specified version of setuptools. Would it make sense to loosen the version of setuptools and pip, so mamba can figure it out based on the fixed python version? Also, another change: can you move Could you try making these changes and commit them to your PR? It will trigger the github actions. Thanks again! |
Yes, I will try to address this until tomorrow. Thanks! |
@gAldeia I believe the tests are not passing, because the MAX_TIME signal is killing the fit method, before it becomes ready for prediction. In the geneticengine regressor, we are setting max_time to 8 hours minus 1 minute. This seems to be too long for the CI test. My suggestion would be for the script to set the max_time accordingly. I assumed that's how it works nowadays, but I can't find it. Some Regressors adjust the max_time, based on the number of instances. Should we standardize on a specific max_time for testing purposes (CI), and for the larger runs, it is set up dynamically? |
I believe it now passes all necessary tests. |
Hi @alcides,
Thanks for pointing that out! I agree that having a Also, I appreciate your effort in making your algorithm fully compatible with SRBench, especially as we work on redesigning everything. Just a minor issue regarding the Operon change you made. I am not confident that I understood what you were trying to do so I did not suggested a way to fix it, but I wrote a comment on that |
I think having a recommended default max_time for CI (for those of us that are doing the integration with SRBench) would kind of solve the problem. Or instead have the scripts define a reasonable max_time (again, for those that support) that is slightly less than the signal-based timeout. The operon bug was reverted. Thanks for pointing it out! |
Thanks @alcides for fixing it! I'll merge your commit now. Continuing the discussion, I think I see what you mean. For CI we should set a very small For official SRBench experiments, we specify a max_time, but give a small margin to let algorithms wrap up what they are doing when the time is out. Also, when running the job in a cluster, make sure that the max time is regarding algorithm's |
This updates GeneticEngine to the latest version.
It also includes three other algorithms:
As previously described, these are fundamental different algorithms, not just different configurations of hyper parameters.