Tracking: removal of IFD in modules

[getchoo]

Import from derivation is a cool and very helpful feature of Nix, but can seriously hurt evaluation performance, and may not be allowed in some cases. We should try to avoid it when possible (in a reasonable way)

Modules that currently require IFD include:

• cava cava sans IFD #376
• fzf
• gh-dash
• imv imv sans IFD #375
• lazygit
• mako mako sans IFD #341
• starship
• swaylock swaylock sans IFD #340
• wezterm

[mightyiam]

Would it still be IFD if sources are flake inputs?

[getchoo]

No, but for the same reason #377 prevents IFD. Flake inputs use builtin fetchers, which would still block evaluation for every port download

See also #388

[stasjok]

I've got 'allow-import-from-derivation' error after updating from here:

nix/modules/home-manager/fzf.nix

Line 8 in 8b6baed

palette = (lib.importJSON "${sources.palette}/palette.json").${cfg.flavor}.colors;

Searching 'importJSON' I found similar usages. Those modules can be added here I think.

[multivac61]

Getting errors in CI after recent update. starship seems to be using IFD.

[getchoo]

Thanks for catching these, The list has been updated 👍

[isabelroses]

As a note I would recommend just disabling starship if you have issues with IFD since starship should match your terminal colours.

[getchoo]

IFD was re-introduced in the lazygit module with #515