Define faces for company

[manankarnik]

Changes:

• Update faces: company-preview, company-preview-search, company-tooltip-search, company-tooltip-search-selection
• Remove obsolete faces: company-scrollbar-bg and company-scrollbar-fg
• Remove TODO

Old:

New:

[bbatsov]

@manankarnik Can you post some actual screenshot with preview search, etc? I'm asking because it seems to me the colors you've picked are not aligned with how the most common library for completion (corfu) is styled and I believe some degree of consistency is important.

[manankarnik]

@bbatsov Sure. I consulted the style guide while picking a color for company-preview-search (Red for Active Search). Although in hindsight, maybe the background should be red instead of the foreground, strictly following the guide. For company-preview I used the comment face, as it seemed the most fitting. For company-tooltip-search and company-tooltip-search-selection I used styles similar to Swiper search.

[bbatsov]

This looks reasonable to me, but as I noted it looks somewhat different from the built-in completion's font-locking right now:

Although in hindsight, maybe the background should be red instead of the foreground, strictly following the guide.

Yeah, this might be better.