Copy markdown-blockquote-face definition to org-quote
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`markdown-mode` may not be loaded by the time Org is used, which results in the `org-quote` face being unstyled (and possibly causing errors).
jtbx
requested changes
Aug 21, 2024
There was a problem hiding this comment.
I've tested your changes and it seems it fixes #123 completely. On the current master I could reproduce the original issue on a simple org document.
I've just got one little thing I would like changed, other than that this looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
(before
markdown-modeis loaded)New:
markdown-modemay not be loaded by the time Org is used, which results in theorg-quoteface being unstyled sincemarkdown-blockquote-faceis not yet defined.I also took the opportunity to remove a seemingly-duplicate entry for
markdown-blockquote-face🤷.Probably fixes #123