From a3a12b48c37030a0c0c03868603209673ff249c7 Mon Sep 17 00:00:00 2001
From: bartes <bartesrlz@gmail.com>
Date: Thu, 10 Jun 2021 12:36:40 +0200
Subject: [PATCH] removed validations for the filter/risk/log endpoints

---
 lib/castle/commands/filter.rb           |  1 -
 lib/castle/commands/log.rb              |  1 -
 lib/castle/commands/risk.rb             |  1 -
 spec/lib/castle/commands/filter_spec.rb | 27 -------------------------
 spec/lib/castle/commands/log_spec.rb    | 27 -------------------------
 spec/lib/castle/commands/risk_spec.rb   | 27 -------------------------
 6 files changed, 84 deletions(-)

diff --git a/lib/castle/commands/filter.rb b/lib/castle/commands/filter.rb
index 062e47e..3a75278 100644
--- a/lib/castle/commands/filter.rb
+++ b/lib/castle/commands/filter.rb
@@ -8,7 +8,6 @@ class << self
         # @param options [Hash]
         # @return [Castle::Command]
         def build(options = {})
-          Castle::Validators::Present.call(options, %i[event])
           context = Castle::Context::Sanitize.call(options[:context])
 
           Castle::Command.new(
diff --git a/lib/castle/commands/log.rb b/lib/castle/commands/log.rb
index 885c3ff..f9532ae 100644
--- a/lib/castle/commands/log.rb
+++ b/lib/castle/commands/log.rb
@@ -8,7 +8,6 @@ class << self
         # @param options [Hash]
         # @return [Castle::Command]
         def build(options = {})
-          Castle::Validators::Present.call(options, %i[event])
           context = Castle::Context::Sanitize.call(options[:context])
 
           Castle::Command.new(
diff --git a/lib/castle/commands/risk.rb b/lib/castle/commands/risk.rb
index 8da46bc..6f49aac 100644
--- a/lib/castle/commands/risk.rb
+++ b/lib/castle/commands/risk.rb
@@ -8,7 +8,6 @@ class << self
         # @param options [Hash]
         # @return [Castle::Command]
         def build(options = {})
-          Castle::Validators::Present.call(options, %i[event])
           context = Castle::Context::Sanitize.call(options[:context])
 
           Castle::Command.new(
diff --git a/spec/lib/castle/commands/filter_spec.rb b/spec/lib/castle/commands/filter_spec.rb
index 8e11aac..f00acc2 100644
--- a/spec/lib/castle/commands/filter_spec.rb
+++ b/spec/lib/castle/commands/filter_spec.rb
@@ -69,31 +69,4 @@
       it { expect(command.data).to be_eql(command_data) }
     end
   end
-
-  describe '#validate!' do
-    subject(:validate!) { instance.build(payload) }
-
-    context 'with event not present' do
-      let(:payload) { {} }
-
-      it do
-        expect { validate! }.to raise_error(
-          Castle::InvalidParametersError,
-          'event is missing or empty'
-        )
-      end
-    end
-
-    context 'with user not present' do
-      let(:payload) { { event: '$login' } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-
-    context 'with event and user present' do
-      let(:payload) { { event: '$login', user: user } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-  end
 end
diff --git a/spec/lib/castle/commands/log_spec.rb b/spec/lib/castle/commands/log_spec.rb
index 454ca87..9efcf29 100644
--- a/spec/lib/castle/commands/log_spec.rb
+++ b/spec/lib/castle/commands/log_spec.rb
@@ -70,31 +70,4 @@
       it { expect(command.data).to be_eql(command_data) }
     end
   end
-
-  describe '#validate!' do
-    subject(:validate!) { instance.build(payload) }
-
-    context 'with event not present' do
-      let(:payload) { {} }
-
-      it do
-        expect { validate! }.to raise_error(
-          Castle::InvalidParametersError,
-          'event is missing or empty'
-        )
-      end
-    end
-
-    context 'with user not present' do
-      let(:payload) { { event: '$login' } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-
-    context 'with event and user present' do
-      let(:payload) { { event: '$login', user: user } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-  end
 end
diff --git a/spec/lib/castle/commands/risk_spec.rb b/spec/lib/castle/commands/risk_spec.rb
index 8981c0a..abbea3f 100644
--- a/spec/lib/castle/commands/risk_spec.rb
+++ b/spec/lib/castle/commands/risk_spec.rb
@@ -70,31 +70,4 @@
       it { expect(command.data).to be_eql(command_data) }
     end
   end
-
-  describe '#validate!' do
-    subject(:validate!) { instance.build(payload) }
-
-    context 'with event not present' do
-      let(:payload) { {} }
-
-      it do
-        expect { validate! }.to raise_error(
-          Castle::InvalidParametersError,
-          'event is missing or empty'
-        )
-      end
-    end
-
-    context 'with user not present' do
-      let(:payload) { { event: '$login' } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-
-    context 'with event and user present' do
-      let(:payload) { { event: '$login', user: user } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-  end
 end