removed validations for the filter/risk/log endpoints

castle · Jun 11, 2021 · a3a12b4 · a3a12b4
1 parent de1faf2
commit a3a12b4
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 84 deletions.
diff --git a/lib/castle/commands/filter.rb b/lib/castle/commands/filter.rb
@@ -8,7 +8,6 @@ class << self
         # @param options [Hash]
         # @return [Castle::Command]
         def build(options = {})
-          Castle::Validators::Present.call(options, %i[event])
           context = Castle::Context::Sanitize.call(options[:context])
 
           Castle::Command.new(

diff --git a/lib/castle/commands/log.rb b/lib/castle/commands/log.rb
@@ -8,7 +8,6 @@ class << self
         # @param options [Hash]
         # @return [Castle::Command]
         def build(options = {})
-          Castle::Validators::Present.call(options, %i[event])
           context = Castle::Context::Sanitize.call(options[:context])
 
           Castle::Command.new(

diff --git a/lib/castle/commands/risk.rb b/lib/castle/commands/risk.rb
@@ -8,7 +8,6 @@ class << self
         # @param options [Hash]
         # @return [Castle::Command]
         def build(options = {})
-          Castle::Validators::Present.call(options, %i[event])
           context = Castle::Context::Sanitize.call(options[:context])
 
           Castle::Command.new(

diff --git a/spec/lib/castle/commands/filter_spec.rb b/spec/lib/castle/commands/filter_spec.rb
@@ -69,31 +69,4 @@
       it { expect(command.data).to be_eql(command_data) }
     end
   end
-
-  describe '#validate!' do
-    subject(:validate!) { instance.build(payload) }
-
-    context 'with event not present' do
-      let(:payload) { {} }
-
-      it do
-        expect { validate! }.to raise_error(
-          Castle::InvalidParametersError,
-          'event is missing or empty'
-        )
-      end
-    end
-
-    context 'with user not present' do
-      let(:payload) { { event: '$login' } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-
-    context 'with event and user present' do
-      let(:payload) { { event: '$login', user: user } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-  end
 end
diff --git a/spec/lib/castle/commands/log_spec.rb b/spec/lib/castle/commands/log_spec.rb
@@ -70,31 +70,4 @@
       it { expect(command.data).to be_eql(command_data) }
     end
   end
-
-  describe '#validate!' do
-    subject(:validate!) { instance.build(payload) }
-
-    context 'with event not present' do
-      let(:payload) { {} }
-
-      it do
-        expect { validate! }.to raise_error(
-          Castle::InvalidParametersError,
-          'event is missing or empty'
-        )
-      end
-    end
-
-    context 'with user not present' do
-      let(:payload) { { event: '$login' } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-
-    context 'with event and user present' do
-      let(:payload) { { event: '$login', user: user } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-  end
 end
diff --git a/spec/lib/castle/commands/risk_spec.rb b/spec/lib/castle/commands/risk_spec.rb
@@ -70,31 +70,4 @@
       it { expect(command.data).to be_eql(command_data) }
     end
   end
-
-  describe '#validate!' do
-    subject(:validate!) { instance.build(payload) }
-
-    context 'with event not present' do
-      let(:payload) { {} }
-
-      it do
-        expect { validate! }.to raise_error(
-          Castle::InvalidParametersError,
-          'event is missing or empty'
-        )
-      end
-    end
-
-    context 'with user not present' do
-      let(:payload) { { event: '$login' } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-
-    context 'with event and user present' do
-      let(:payload) { { event: '$login', user: user } }
-
-      it { expect { validate! }.not_to raise_error }
-    end
-  end
 end