Bump SQLAlchemy to 2.0 #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mypy is a bit dumb |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 69.02% 63.58% -5.44%
==========================================
Files 92 98 +6
Lines 8674 10565 +1891
==========================================
+ Hits 5987 6718 +731
- Misses 2687 3847 +1160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
prusnak
suggested changes
Sep 28, 2024
lollerfirst
force-pushed
the
sqlalchemy-bump
branch
from
f5d22c6
to
7f9bfdf
Compare
prusnak
suggested changes
Sep 30, 2024
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
prusnak
suggested changes
Oct 3, 2024
poetry.lock
Outdated
|
|
||
| [metadata] | ||
| lock-version = "2.0" | ||
| python-versions = "^3.8.1" | ||
| content-hash = "38db19797cb04d1f941f6f58c56c8dfe09ac34d45ac2f654bc97dd8110912da8" | ||
| content-hash = "1676da5d07d195f219cdb1338bdf693da20b971d904cae87812a30ddc31a76c0" |
There was a problem hiding this comment.
on my machine running poetry lock --no-update leads to a different content-hash:
Suggested change
| content-hash = "1676da5d07d195f219cdb1338bdf693da20b971d904cae87812a30ddc31a76c0" | |
| content-hash = "47f05f6093dbe0e04bb135e76c8e51cb306dd358fa5259fbbad6e24b005750d3" |
There was a problem hiding this comment.
should be fine now.
prusnak
approved these changes
Oct 3, 2024
callebtc
reviewed
Oct 5, 2024
callebtc
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of warnings for basically the same thing: use
_mappingfor dictionary interface toRow.