ops: don't re-apply already applied operations #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hermit environment variable operations can be overrode by the user after an environment has already been opened. If this is the case, then we shouldn't re-apply the operations; we should instead expressed respect the wish of a mangled environment by the user. This is relevant for constructs like Python virutal environments. Context: https://square.slack.com/archives/C01RTEH4MFV/p1685522543591719
quad
force-pushed
the
ssr/20230531/skip-envar-reapply
branch
from
f62ba38 to
3d9ca9b
Compare
|
Closed in favour of #250. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This solution is horrible as it interacts with the
HERMIT_ENV_OPSenvar setup in the activate script. I'd appreciate suggestions for a better approach!)Hermit environment variable operations can be overrode by the user after
an environment has already been opened. If this is the case, then we
shouldn't re-apply the operations; we should instead expressed respect
the wish of a mangled environment by the user.
This is relevant for constructs like Python virtual environments.
Context: https://square.slack.com/archives/C01RTEH4MFV/p1685522543591719