feat: Git manifest sources can now specify a reference to pin to #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was in the documentation but not implemented (as discovered in #342). `#<tag>` was supported for Git packages, so I've factored that code out and reused it. Added an integration test for this, along with a couple of new test helper functions that should make these kind of tests simpler in the future.
jvmakine
approved these changes
Nov 13, 2022
|
I think I will change this a bit. Packages want a fast checkout because they're cloned for each install, while sources want the ability to update. Using |
|
@alecthomas any thoughts on finalizing/merging this? |
|
@alecthomas one last ping :) |
|
Alas, I just don't have time at the moment 😢 |
spicykay
pushed a commit
to spicykay/hermit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was in the documentation but not implemented
(as discovered in #342).
#<tag>was supported for Git packages, so I've factored that code out and reused it.Added an integration test for this, along with a couple of new test helper functions that should make these kind of tests simpler in the future.