Improve hit test performance by optimizing X axis #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickEntin
commented
Jan 4, 2024
| @@ -11,7 +11,7 @@ | |||
| <key>com.apple.XCTPerformanceMetric_WallClockTime</key> | |||
| <dict> | |||
| <key>baselineAverage</key> | |||
| <real>17.200000</real> | |||
| <real>5.930000</real> | |||
There was a problem hiding this comment.
Setting both to 2 brings it down to 1.961 sec.
Setting both to 4 brings it down to 1.074 sec.
NickEntin
force-pushed
the
entin/hit-test-snapshot-performance-2
branch
from
a5f632b to
f1b9f92
Compare
NickEntin
commented
Jan 5, 2024
| } | ||
| } | ||
|
|
||
| // Finish the scan line if necessary. | ||
| if let lastHit = lastHit, let lastHitView = lastHit.1 { | ||
| scanLine.append(((lastHit.0...bounds.maxX), lastHitView)) | ||
| if lastHit.0 != bounds.maxX { |
There was a problem hiding this comment.
Oh wait, this has a similar problem to the Y axis. This assumes the maxPermissibleMissedRegionWidth will get you very close to the edge of the bounds, but if the width isn't nicely divisible by the step size this might not be true. I think we need another stride here to finish off the pass.
There was a problem hiding this comment.
Vertical scroll indicator might be a good example of where this could fail right now
Base automatically changed from
entin/hit-test-snapshot-performance
to
master
January 19, 2024 00:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.