Skip to content

Commit

Permalink
Merge pull request #195 from cashapp/entin/ios-17
Browse files Browse the repository at this point in the history
Add snapshot tests for iOS 17
  • Loading branch information
NickEntin authored Jan 27, 2024
2 parents ccee9fe + b5741bb commit 8179c09
Show file tree
Hide file tree
Showing 99 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: macOS-13
strategy:
matrix:
platform: ['iOS_16']
platform: ['iOS_17', 'iOS_16']
fail-fast: false
steps:
- name: Checkout Repo
Expand Down
1 change: 1 addition & 0 deletions Example/SnapshotTests/ImpreciseObjectiveCTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ - (void)setUp;
[super setUp];

self.fileNameOptions = FBSnapshotTestCaseFileNameIncludeOptionOS | FBSnapshotTestCaseFileNameIncludeOptionScreenSize | FBSnapshotTestCaseFileNameIncludeOptionScreenScale;
self.recordMode = NO;
}

- (void)testSimpleView;
Expand Down
1 change: 1 addition & 0 deletions Example/SnapshotTests/ObjectiveCTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ - (void)setUp;
[super setUp];

self.fileNameOptions = FBSnapshotTestCaseFileNameIncludeOptionOS | FBSnapshotTestCaseFileNameIncludeOptionScreenSize | FBSnapshotTestCaseFileNameIncludeOptionScreenScale;
self.recordMode = NO;
}

- (void)testSimpleView;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions Example/SnapshotTests/SnapshotTestCase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class SnapshotTestCase: FBSnapshotTestCase {
// MARK: - Private Static Properties

private static let testedDevices = [
TestDeviceConfig(systemVersion: "17.2", screenSize: CGSize(width: 393, height: 852), screenScale: 3),
TestDeviceConfig(systemVersion: "16.4", screenSize: CGSize(width: 393, height: 852), screenScale: 3),
TestDeviceConfig(systemVersion: "14.5", screenSize: CGSize(width: 390, height: 844), screenScale: 3),
TestDeviceConfig(systemVersion: "13.7", screenSize: CGSize(width: 375, height: 812), screenScale: 3),
Expand Down
3 changes: 3 additions & 0 deletions Scripts/build.swift
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,15 @@ enum TaskError: Error {
}

enum Platform: String, CustomStringConvertible {
case iOS_17
case iOS_16
case iOS_14
case iOS_13

var destination: String {
switch self {
case .iOS_17:
return "platform=iOS Simulator,OS=17.2,name=iPhone 14 Pro"
case .iOS_16:
return "platform=iOS Simulator,OS=16.4,name=iPhone 14 Pro"
case .iOS_14:
Expand Down

0 comments on commit 8179c09

Please sign in to comment.