Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile & docker-compose.yaml file to simplify setup steps #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andy11
Copy link
Contributor

@andy11 andy11 commented Aug 22, 2024

run with docker-compose up --build

not sure if it's ready for wider use and worth adding to the main README yet, but let me know what you think

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
play-money-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:07pm
play-money-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:07pm

@casesandberg
Copy link
Owner

This looks great!

I am pulled down to run locally and am running into an issue with the change you made in the env that changes @localhost to @db. It errors out until I put that back. Is this something custom you did on your machine to map that or something?

@andy11
Copy link
Contributor Author

andy11 commented Aug 27, 2024

hmm that's strange, docker-compose should allow containers to be looked up by their service name ("By default Compose sets up a single network for your app. Each container for a service joins the default network and is both reachable by other containers on that network, and discoverable by the service's name." + example from https://docs.docker.com/compose/networking/)

was the error you saw with the DNS resolution or TCP connection?

@casesandberg
Copy link
Owner

Oh sorry, I meant this is erroring when not using the docker setup. My setup is as if you just cloned the repo into a folder, ran install and the run dev.

@andy11
Copy link
Contributor Author

andy11 commented Sep 9, 2024

ahh got it. sorry I got pulled into other things, but will try to pick this back up later this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants