Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copyright notices to Carvel Authors #1506

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Mar 14, 2024

What this PR does / why we need it:

Change copyright notices to Carvel Authors in every file there was already a copyright header.

Which issue(s) this PR fixes:

Fixes #1503

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

None

I created a script with logging to make these changes. The log for all the Carvel repo changes is here: https://gist.github.com/bentito/c39c38282dd4c856a79f8adb7394180e
NB: vendor dirs are all ignored as are any non go, py, js, cpp, or c files, though I think in practice there were only copyright headers on .go files.

Signed-off-by: Brett Tofel <btofel@redhat.com>
@sethiyash
Copy link
Contributor

Hello @bentito,

Thank you so much for submitting this pull request! Your contributions are greatly appreciated.

The changes you've made to the files look fantastic. I've had a chance to review them, and everything seems to be in order.

I noticed that we also have a GitHub action in place that checks for the Go header based on this template. It would be wonderful if we could modify this template to reflect The Carvel Authors instead of VMware.

If you need any assistance or guidance along the way, please don't hesitate to reach out. I look forward to collaborating with you further!

Signed-off-by: Brett Tofel <btofel@redhat.com>
@bentito
Copy link
Contributor Author

bentito commented Mar 25, 2024

Hello @bentito,

Thank you so much for submitting this pull request! Your contributions are greatly appreciated.

The changes you've made to the files look fantastic. I've had a chance to review them, and everything seems to be in order.

I noticed that we also have a GitHub action in place that checks for the Go header based on this template. It would be wonderful if we could modify this template to reflect The Carvel Authors instead of VMware.

If you need any assistance or guidance along the way, please don't hesitate to reach out. I look forward to collaborating with you further!

@sethiyash ok, made the change.

@bentito
Copy link
Contributor Author

bentito commented Mar 27, 2024

@sethiyash I think this might be all set to merge now?

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution @bentito!

@praveenrewar praveenrewar merged commit 6f2515e into carvel-dev:develop Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update copyright headers
3 participants