Skip to content

Commit

Permalink
Merge pull request #2716 from carpentries/frog-artifact-1
Browse files Browse the repository at this point in the history
Update upload-artifact version to v4
  • Loading branch information
pbanaszkiewicz authored Jan 14, 2025
2 parents 06f3edf + 13b722c commit a8adf4c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/accessibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ jobs:
# pa11y runs faster and produces smaller artifacts
# lighthouse includes performance tests and other checks for non-a11y best practices
# for now, just use pa11y as we focus on improving a11y specifically
package: ["pa11y"]
package: ["pa11y"]
fail-fast: false # don't cancel lighthouse job if pa11y fails, and vice versa
env:
AMY_DATABASE_HOST: localhost
AMY_DATABASE_PORT: 5432
AMY_DATABASE_NAME: test_amy
AMY_DATABASE_USER: postgres
AMY_DATABASE_PASSWORD: postgres
AMY_DATABASE_PASSWORD: postgres
AMY_INSTRUCTOR_RECRUITMENT_ENABLED: True

services:
Expand All @@ -40,7 +40,7 @@ jobs:
--health-retries 5
ports:
- 5432:5432

steps:

# Database setup
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:

- name: run Lighthouse CI
run: |
npm install -g @lhci/cli@0.12.x
npm install -g @lhci/cli@0.12.x
npm install -g puppeteer
lhci autorun
env:
Expand All @@ -109,7 +109,7 @@ jobs:
if: matrix.package == 'lighthouse'

# Pa11y

- name: Start server in background
run: |
pipenv run make serve &
Expand All @@ -123,7 +123,7 @@ jobs:
continue-on-error: true

- name: Upload pa11y test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pa11y-ci-report
path: pa11y-ci-report/
Expand Down

0 comments on commit a8adf4c

Please sign in to comment.