Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

ZNK tweaks #13

Merged
merged 6 commits into from
Sep 19, 2022
Merged

ZNK tweaks #13

merged 6 commits into from
Sep 19, 2022

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Sep 19, 2022

I noticed some small things in the lesson setup that I thought I might tweak to improve consistency:

  1. stripped the prefix from the episodes and explicitly put them in the schedule
  2. updated the data links to point to files in this lesson instead of outside files
  3. fixed the title of the lesson to match the repo description
  4. changed all instances of F to FALSE (as a recovering population geneticist, this one is particularly nefarious).
  5. removed the unused renv.lock at the top of the directory.

There were two issues with these links:

1. the link names were very long (imagine sitting through a screen
   reader reading that entire URL out loud)
2. the links were going to an external resource when the files are
   up-to-date here.
@github-actions
Copy link

github-actions bot commented Sep 19, 2022

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/R-ecology-lesson/compare/md-outputs..md-outputs-PR-13

The following changes were observed in the rendered markdown documents:

 05-extra-challenges.md => extra-challenges.md      |   0
 ...ing-ggplot-rendered-boxplot-jitter-1.png (gone) | Bin 405038 -> 0 bytes
 ...g-ggplot-rendered-boxplot-outliers-1.png (gone) | Bin 401999 -> 0 bytes
 ...dered-customizing-challenge-answer-1.png (gone) | Bin 776387 -> 0 bytes
 ...zing-ggplot-rendered-element-blank-1.png (gone) | Bin 652407 -> 0 bytes
 ...alizing-ggplot-rendered-facet-wrap-1.png (gone) | Bin 558330 -> 0 bytes
 ...isualizing-ggplot-rendered-fill-na-1.png (gone) | Bin 634731 -> 0 bytes
 ...alizing-ggplot-rendered-geom-color-1.png (gone) | Bin 655745 -> 0 bytes
 ...izing-ggplot-rendered-global-color-1.png (gone) | Bin 652070 -> 0 bytes
 ...visualizing-ggplot-rendered-labels-1.png (gone) | Bin 796680 -> 0 bytes
 ...zing-ggplot-rendered-legend-remove-1.png (gone) | Bin 810962 -> 0 bytes
 ...ing-ggplot-rendered-reverse-layers-1.png (gone) | Bin 502566 -> 0 bytes
 ...ualizing-ggplot-rendered-text-size-1.png (gone) | Bin 651988 -> 0 bytes
 ...sualizing-ggplot-rendered-theme-bw-1.png (gone) | Bin 658262 -> 0 bytes
 ...ng-ggplot-rendered-unnamed-chunk-1-1.png (gone) | Bin 630297 -> 0 bytes
 ...t-rendered-violin-challenge-answer-1.png (gone) | Bin 564067 -> 0 bytes
 ...rendered-violin-challenge-answer-2-1.png (gone) | Bin 569953 -> 0 bytes
 ...endered-date-plot-challenge-answer-1.png (gone) | Bin 454220 -> 0 bytes
 ...=> visualizing-ggplot-rendered-bare-plot-1.png} | Bin
 ...isualizing-ggplot-rendered-blank-boxplot-1.png} | Bin
 ...g => visualizing-ggplot-rendered-boxplot-1.png} | Bin
 ...isualizing-ggplot-rendered-boxplot-color-1.png} | Bin
 ...visualizing-ggplot-rendered-boxplot-fill-1.png} | Bin
 ...zing-ggplot-rendered-boxplot-jitter-1.png (new) | Bin 0 -> 406270 bytes
 ...izing-ggplot-rendered-boxplot-label-wrap-1.png} | Bin
 ...ng-ggplot-rendered-boxplot-outliers-1.png (new) | Bin 0 -> 401854 bytes
 ...sualizing-ggplot-rendered-boxplot-points-1.png} | Bin
 ...visualizing-ggplot-rendered-change-alpha-1.png} | Bin
 ...visualizing-ggplot-rendered-change-color-1.png} | Bin
 ...ualizing-ggplot-rendered-color-plot-type-1.png} | Bin
 ...ndered-customizing-challenge-answer-1.png (new) | Bin 0 -> 779492 bytes
 ...izing-ggplot-rendered-element-blank-1.png (new) | Bin 0 -> 650100 bytes
 ...ualizing-ggplot-rendered-facet-wrap-1.png (new) | Bin 0 -> 557368 bytes
 ...visualizing-ggplot-rendered-fill-na-1.png (new) | Bin 0 -> 633894 bytes
 ...ualizing-ggplot-rendered-geom-color-1.png (new) | Bin 0 -> 653001 bytes
 ...lizing-ggplot-rendered-global-color-1.png (new) | Bin 0 -> 650809 bytes
 fig/visualizing-ggplot-rendered-labels-1.png (new) | Bin 0 -> 801002 bytes
 ...izing-ggplot-rendered-legend-remove-1.png (new) | Bin 0 -> 808452 bytes
 ...t-rendered-modify-color-challenge-answer-1.png} | Bin
 ...-rendered-modify-points-challenge-answer-1.png} | Bin
 ...sualizing-ggplot-rendered-plot-with-axes-1.png} | Bin
 ...zing-ggplot-rendered-reverse-layers-1.png (new) | Bin 0 -> 504472 bytes
 ...=> visualizing-ggplot-rendered-scale-log-1.png} | Bin
 ...isualizing-ggplot-rendered-scale-viridis-1.png} | Bin
 ...visualizing-ggplot-rendered-scatter-plot-1.png} | Bin
 ...sualizing-ggplot-rendered-text-size-1.png (new) | Bin 0 -> 654805 bytes
 ...isualizing-ggplot-rendered-theme-bw-1.png (new) | Bin 0 -> 656965 bytes
 ...ing-ggplot-rendered-unnamed-chunk-1-1.png (new) | Bin 0 -> 638777 bytes
 ...ot-rendered-violin-challenge-answer-1.png (new) | Bin 0 -> 566578 bytes
 ...-rendered-violin-challenge-answer-2-1.png (new) | Bin 0 -> 569556 bytes
 ...rendered-date-plot-challenge-answer-1.png (new) | Bin 0 -> 454767 bytes
 ...ta-rendered-time-series-challenge-answer-1.png} | Bin
 ...nks-about-data.md => how-r-thinks-about-data.md |   0
 ...ction-r-rstudio.md => introduction-r-rstudio.md |   0
 md5sum.txt                                         |  29 +++++-----
 setup.md                                           |   9 ++-
 01-visualizing-ggplot.md => visualizing-ggplot.md  |  64 ++++++++++-----------
 03-working-with-data.md => working-with-data.md    |   4 +-
 58 files changed, 54 insertions(+), 52 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2022-09-19 17:31:24 +0000

github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
@MCMaurer MCMaurer merged commit 2941377 into main Sep 19, 2022
@MCMaurer
Copy link
Collaborator

Thanks for all the helpful edits @zkamvar!!

@MCMaurer MCMaurer deleted the znk-edits branch September 19, 2022 21:15
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
Auto-generated via {sandpaper}
Source  : 2941377
Branch  : main
Author  : Michael Culshaw-Maurer <culshawmaurer@email.arizona.edu>
Time    : 2022-09-19 21:15:11 +0000
Message : Merge pull request #13 from carpentries-incubator/znk-edits

ZNK tweaks
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
Auto-generated via {sandpaper}
Source  : f43d306
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2022-09-19 21:19:19 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 2941377
Branch  : main
Author  : Michael Culshaw-Maurer <culshawmaurer@email.arizona.edu>
Time    : 2022-09-19 21:15:11 +0000
Message : Merge pull request #13 from carpentries-incubator/znk-edits

ZNK tweaks
github-actions bot pushed a commit that referenced this pull request Sep 20, 2022
Auto-generated via {sandpaper}
Source  : 2941377
Branch  : main
Author  : Michael Culshaw-Maurer <culshawmaurer@email.arizona.edu>
Time    : 2022-09-19 21:15:11 +0000
Message : Merge pull request #13 from carpentries-incubator/znk-edits

ZNK tweaks
github-actions bot pushed a commit that referenced this pull request Sep 20, 2022
Auto-generated via {sandpaper}
Source  : f2da5e3
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2022-09-20 01:53:24 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 2941377
Branch  : main
Author  : Michael Culshaw-Maurer <culshawmaurer@email.arizona.edu>
Time    : 2022-09-19 21:15:11 +0000
Message : Merge pull request #13 from carpentries-incubator/znk-edits

ZNK tweaks
github-actions bot pushed a commit that referenced this pull request Sep 27, 2022
Auto-generated via {sandpaper}
Source  : f2da5e3
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2022-09-20 01:53:24 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 2941377
Branch  : main
Author  : Michael Culshaw-Maurer <culshawmaurer@email.arizona.edu>
Time    : 2022-09-19 21:15:11 +0000
Message : Merge pull request #13 from carpentries-incubator/znk-edits

ZNK tweaks
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
Auto-generated via {sandpaper}
Source  : f2da5e3
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2022-09-20 01:53:24 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 2941377
Branch  : main
Author  : Michael Culshaw-Maurer <culshawmaurer@email.arizona.edu>
Time    : 2022-09-19 21:15:11 +0000
Message : Merge pull request #13 from carpentries-incubator/znk-edits

ZNK tweaks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants