Modify generator.NewCatalogSourcedNameGenerator to return also an error #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an error generator
…en pushed into the catalog constructor
carloscasalar
deleted the
16-modify-generatornewcatalogsourcednamegenerator-to-return-also-an-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a catalog-based name generator, the validation rules are attached to the struct representing the catalog file. I want to push that validation logic into the catalog-sourced name generator as the rules are the same, no matter if they come from a file or from a hardcoded list.
This MR pushes the validation logic into the
NewCatalogSourcedNameGeneratorconstructor.