Port Telemetry Data (see #5153) #8592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port Telemetry Data to UE5
Checklist:
ue5-devbranch and tested with latest changesmake check(only Linux)Description
This PR aims to match the TelemetryData feature that has been made on the UE4 version on PR #5153. This does not compile at the moment as it is missing some structures and methods to access the telemetry data. If someone is interested into helping me add the missing code, please reach out. This PR comes from #8560 .
```
[1/3] Compile Module.Carla.11.cpp
In file included from /home/--/Documents/carla/Unreal/CarlaUnreal/Intermediate/Build/Linux/x64/CarlaUnreal/Development/Carla/Module.Carla.11.cpp:33:
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:656:48: error: no member named 'GetEngineRotationSpeed' in 'UChaosVehicleMovementComponent'
656 | TelemetryData.EngineRPM = MovementComponent->GetEngineRotationSpeed();
| ~~~~~~~~~~~~~~~~~ ^
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:661:3: error: unknown type name 'FPhysXVehicleManager'; did you mean 'FChaosVehicleManager'?
661 | FPhysXVehicleManager* MyVehicleManager = FPhysXVehicleManager::GetVehicleManagerFromScene(GetWorld()->GetPhysicsScene());
| ^~~~~~~~~~~~~~~~~~~~
| FChaosVehicleManager
/home/--/Documents/UnrealEngine5_carla/Engine/Plugins/Experimental/ChaosVehiclesPlugin/Source/ChaosVehicles/Public/ChaosVehicleWheel.h:24:7: note: 'FChaosVehicleManager' declared here
24 | class FChaosVehicleManager;
| ^
In file included from /home/charles/Documents/carla/Unreal/CarlaUnreal/Intermediate/Build/Linux/x64/CarlaUnreal/Development/Carla/Module.Carla.11.cpp:33:
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:661:44: error: use of undeclared identifier 'FPhysXVehicleManager'; did you mean 'FChaosVehicleManager'?
661 | FPhysXVehicleManager* MyVehicleManager = FPhysXVehicleManager::GetVehicleManagerFromScene(GetWorld()->GetPhysicsScene());
| ^~~~~~~~~~~~~~~~~~~~
| FChaosVehicleManager
/home/--/Documents/UnrealEngine5_carla/Engine/Plugins/Experimental/ChaosVehiclesPlugin/Source/ChaosVehicles/Public/ChaosVehicleWheel.h:24:7: note: 'FChaosVehicleManager' declared here
24 | class FChaosVehicleManager;
| ^
In file included from /home/--/Documents/carla/Unreal/CarlaUnreal/Intermediate/Build/Linux/x64/CarlaUnreal/Development/Carla/Module.Carla.11.cpp:33:
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:661:44: error: incomplete type 'FChaosVehicleManager' named in nested name specifier
661 | FPhysXVehicleManager* MyVehicleManager = FPhysXVehicleManager::GetVehicleManagerFromScene(GetWorld()->GetPhysicsScene());
| ^~~~~~~~~~~~~~~~~~~~~~
/home/--/Documents/UnrealEngine5_carla/Engine/Plugins/Experimental/ChaosVehiclesPlugin/Source/ChaosVehicles/Public/ChaosVehicleWheel.h:24:7: note: forward declaration of 'FChaosVehicleManager'
24 | class FChaosVehicleManager;
| ^
In file included from /home/charles/Documents/carla/Unreal/CarlaUnreal/Intermediate/Build/Linux/x64/CarlaUnreal/Development/Carla/Module.Carla.11.cpp:33:
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:663:42: error: member access into incomplete type 'FChaosVehicleManager'
663 | SCOPED_SCENE_READ_LOCK(MyVehicleManager->GetScene());
| ^
/home/--/Documents/UnrealEngine5_carla/Engine/Plugins/Experimental/ChaosVehiclesPlugin/Source/ChaosVehicles/Public/ChaosVehicleWheel.h:24:7: note: forward declaration of 'FChaosVehicleManager'
24 | class FChaosVehicleManager;
| ^
In file included from /home/--/Documents/carla/Unreal/CarlaUnreal/Intermediate/Build/Linux/x64/CarlaUnreal/Development/Carla/Module.Carla.11.cpp:33:
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:664:3: error: unknown type name 'PxWheelQueryResult'
664 | PxWheelQueryResult* WheelsStates = MyVehicleManager->GetWheelsStates_AssumesLocked(MovementComponent);
| ^
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:664:54: error: member access into incomplete type 'FChaosVehicleManager'
664 | PxWheelQueryResult* WheelsStates = MyVehicleManager->GetWheelsStates_AssumesLocked(MovementComponent);
| ^
/home/--/Documents/UnrealEngine5_carla/Engine/Plugins/Experimental/ChaosVehiclesPlugin/Source/ChaosVehicles/Public/ChaosVehicleWheel.h:24:7: note: forward declaration of 'FChaosVehicleManager'
24 | class FChaosVehicleManager;
| ^
In file included from /home/--/Documents/carla/Unreal/CarlaUnreal/Intermediate/Build/Linux/x64/CarlaUnreal/Development/Carla/Module.Carla.11.cpp:33:
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:668:45: error: no member named 'PVehicle' in 'UChaosVehicleMovementComponent'
668 | for (uint32 w = 0; w < MovementComponent->PVehicle->mWheelsSimData.getNbWheels(); ++w)
| ~~~~~~~~~~~~~~~~~ ^
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:675:51: error: no member named 'PVehicle' in 'UChaosVehicleMovementComponent'
675 | WheelTelemetryData.Omega = MovementComponent->PVehicle->mWheelsDynData.getWheelRotationSpeed(w);
| ~~~~~~~~~~~~~~~~~ ^
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:677:5: error: unknown type name 'UVehicleWheel'
677 | UVehicleWheel* Wheel = MovementComponent->Wheels[w];
| ^
/home/--/Documents/carla/Unreal/CarlaUnreal/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp:677:47: error: no member named 'Wheels' in 'UChaosVehicleMovementComponent'
677 | UVehicleWheel* Wheel = MovementComponent->Wheels[w];
| ~~~~~~~~~~~~~~~~~ ^
11 errors generated.
``
Where has this been tested?
Possible Drawbacks
It might seem like duplicated code from the ue4-branch. Carla UE5 might also not be ready yet for this patch if too much background work has to be done.
This change is