Added Parameter: credentials_path to AuthenticatedAPI / APIs & Updated ParAPI Login #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a update identifiers function.
Added a number of if statements to XML finds, to handle cases where a "None" option has been utilised and returned. Changed Policies to a PagedSet to allow for more than 250 results (there also was a bug, where the policies call would only return 100 results).
|
reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this as a parameter to AuthenticatedAPI and, where used, by API Classes / Functions.
This way you can have a single credentials.properties file located in X place, and the given script can just point towards it. Still defaults to the relative path of script in cwd, so by default operates in the established way.
One thing I'm not sure about are the changes to ParAPI, as I forgot the ParAPI logins differently. In testing the changes seemed to work fine.