Add fitted preview on playground panel #2133
Merged
+363
−345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burieberry
force-pushed
the
cs-7914-playground-fitted-format
branch
from
b23e604 to
1c27a68
Compare
The Percy diffs suggest some unintentional changes elsewhere, or is it a weird merge situation? |
I updated the BasicFitted component based on the new designs, which is why everything looks different. I'm checking with design whether this is intentional. |
backspace
approved these changes
Feb 13, 2025
| style={{setContainerSize spec}} | ||
| /> | ||
| </li> | ||
| {{/each}} |
There was a problem hiding this comment.
I appreciate this abstraction 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fitted-format-galleryto match the new format specsAn issue I'm facing is that any place where the cards are pre-rendered, I'm not seeing the changes I made. Might be a caching issue -- will try again.