Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reprocessing matrix events #2127

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions packages/host/app/resources/room.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ interface Args {

export class RoomResource extends Resource<Args> {
private _previousRoomId: string | undefined;
private _processedEvents = new Set<string>();
private _messageCache: TrackedMap<string, Message> = new TrackedMap();
private _skillCardsCache: TrackedMap<string, SkillCard> = new TrackedMap();
private _nameEventsCache: TrackedMap<string, RoomNameEvent> =
Expand Down Expand Up @@ -98,6 +99,7 @@ export class RoomResource extends Resource<Args> {
}

private resetCache() {
this._processedEvents.clear();
this._messageCache = new TrackedMap();
this._memberCache = new TrackedMap();
this._fragmentCache = new TrackedMap();
Expand Down Expand Up @@ -138,7 +140,7 @@ export class RoomResource extends Resource<Args> {
return this.members.filter((m) => m.membership === 'join');
}

private get events() {
private get events(): DiscreteMatrixEvent[] {
return this.matrixRoom?.events ?? [];
}

Expand Down Expand Up @@ -249,7 +251,19 @@ export class RoomResource extends Resource<Args> {
private async loadFromEvents(roomId: string) {
let index = this._messageCache.size;

for (let event of this.sortedEvents) {
// We want to avoid reprocessing events, here we pick the
// first unprocessed event and run everything in order from there
const firstUnprocessedIndex = this.sortedEvents.findIndex(
(event) => !this._processedEvents.has(event.event_id),
);

if (firstUnprocessedIndex === -1) {
// All events have been processed
return;
}

for (let i = firstUnprocessedIndex; i < this.sortedEvents.length; i++) {
const event = this.sortedEvents[i];
switch (event.type) {
case 'm.room.member':
await this.loadRoomMemberEvent(roomId, event);
Expand All @@ -267,6 +281,7 @@ export class RoomResource extends Resource<Args> {
await this.loadRoomNameEvent(event);
break;
}
this._processedEvents.add(event.event_id);
}
}

Expand Down
Loading