-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Picker for Attaching Files #2126
Conversation
a4a11d9
to
e8e4147
Compare
e8e4147
to
bd7af13
Compare
@FadhlanR I have a draft PR up for displaying |
@jurgenwerk if this PR is ok to merge, I'll merge it and will rebase your PR. The feature flag introduced in this PR also can be used in yours. |
…nto-the-ai-assistant' into cs-7948-file-picker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected.
…nto-the-ai-assistant' into cs-7948-file-picker
@FadhlanR I was testing this and see this PR already includes the autoattached behaviour from #2135. So I see no point in maintaining a separate PR anymore since your PR now has that functionality almost in whole. I suggest you merge (or cherry pick the new commits if that is easier) my latest changes (my PR branch is green and ready to go). The latest changes include removing files from being attached, a test, and some type adjustments. I chose not to implement a resource for the autoattached files like we do with attached cards because here the situation is much simpler since we don't have any stacks, just the currently opened file. Let me know if you are ok with rebasing and then we can close my PR and move the rest of the todo into a separate ticket. |
Sounds good. I'll include your latest updates to this PR. |
@jurgenwerk I've rebased this PR to your latest updates. And I made some updates for the auto-attached file. |
return cards; | ||
} | ||
|
||
private get allFilesToAttach() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using "all" in the name is redundant. We can just use filesToAttach
. It should include all files shown in the attachments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged autoAttachedFile
and filesToAttach
directly in the sendMessage
function, following the same approach we use for autoAttachedCards
and cardsToAttach
.
Screen.Recording.2025-02-11.at.15.33.02.mov