Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading state rhs #2121

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Fix loading state rhs #2121

merged 8 commits into from
Feb 11, 2025

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Feb 5, 2025

The idea is of this PR

  • get loading state of spec to work inside its content
  • change schema editor to do the same
  • schema editor to have the same inline style for playground, spec-preview and schema editor (the positioning is not the same tho). I guess we can also make schema editor work like the other but I notice the outer div with ...attributes means a lot of styling is gotten from the parent

Schema editor

Before:

Screenshot 2025-02-05 at 16 40 18

After:

Screenshot 2025-02-05 at 20 46 36

Spec

Before: Spec also worked like this where but I hid it in a previous PR.

After:

Screenshot 2025-02-05 at 20 49 31

Copy link

github-actions bot commented Feb 5, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   23m 35s ⏱️ -5s
756 tests ±0  754 ✔️ ±0  2 💤 ±0  0 ±0 
761 runs  ±0  759 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 4d11893. ± Comparison against base commit 02de772.

♻️ This comment has been updated with latest results.

@tintinthong tintinthong requested review from a team and burieberry February 5, 2025 08:46
@tintinthong
Copy link
Contributor Author

@burieberry should we make spec to have the loading on the top left instead??

@burieberry
Copy link
Contributor

@burieberry should we make spec to have the loading on the top left instead??

Would be good to keep them all consistent

Copy link
Contributor

@burieberry burieberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tintinthong tintinthong merged commit e4f0149 into main Feb 11, 2025
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants