Remove description from top level of function calls #2110
Conversation
FadhlanR
commented
Jan 31, 2025
•
FadhlanR
commented
- Removed the description from the function call parameters.
- Used the content of the response message instead of the function call description.
| @@ -260,87 +260,4 @@ module('Responding', (hooks) => { | |||
| 'The tool call event should replace the thinking message', | |||
| ); | |||
| }); | |||
|
|
|||
| test('Sends tool call event separately when content is sent before tool call', async () => { | |||
There was a problem hiding this comment.
I think this test is no longer relevant.
| @@ -42,7 +42,8 @@ You may make multiple function calls, all calls are gated by the user so multipl | |||
| If a user asks you about things in the world, use your existing knowledge to help them. Only if necessary, add a *small* caveat at the end of your message to explain that you do not have live external data. \ | |||
| \ | |||
| If you need access to the cards the user can see, you can ask them to attach the cards. \ | |||
| If you encounter JSON structures, please enclose them within backticks to ensure they are displayed stylishly in Markdown.'; | |||
| If you encounter JSON structures, please enclose them within backticks to ensure they are displayed stylishly in Markdown. \ | |||
| Always provide a content text explanation before calling a function'; | |||
There was a problem hiding this comment.
@IanCal does this need to be phrased differently to help it keep the context text and the function in the same response?
There was a problem hiding this comment.
It'll never return more than one response, I would be tempted to leave this until we see lots of calls we want an explanation with coming without them, and ideally have evals to see the difference it makes. It may be different for different models.
| @@ -42,7 +42,8 @@ You may make multiple function calls, all calls are gated by the user so multipl | |||
| If a user asks you about things in the world, use your existing knowledge to help them. Only if necessary, add a *small* caveat at the end of your message to explain that you do not have live external data. \ | |||
| \ | |||
| If you need access to the cards the user can see, you can ask them to attach the cards. \ | |||
| If you encounter JSON structures, please enclose them within backticks to ensure they are displayed stylishly in Markdown.'; | |||
| If you encounter JSON structures, please enclose them within backticks to ensure they are displayed stylishly in Markdown. \ | |||
| Always provide a content text explanation before calling a function'; | |||
There was a problem hiding this comment.
It'll never return more than one response, I would be tempted to leave this until we see lots of calls we want an explanation with coming without them, and ideally have evals to see the difference it makes. It may be different for different models.
| roomId: this.roomId, | ||
| content: msg.content, | ||
| functionCall: this.deserializeToolCall(toolCall), | ||
| eventToUpdate: this.initialMessageId, |
There was a problem hiding this comment.
If there is more than one tool call, does this still work? It looks like it might replace the initial event with each tool call resulting in just one at the end
|
Without a change to host, it looks like this will still create the same wrapper around everything? Ideally we want to go from to |
