Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding renderType flag to prerendered search endpoint #2107

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

FadhlanR
Copy link
Contributor

@FadhlanR FadhlanR commented Jan 30, 2025

This PR introduces a new parameter called renderType to the prerendered search endpoint. If this parameter is defined, we will return the corresponding HTML; if it is not defined or if the HTML is not found, we will return whatever is available. Additionally, I have added a usedRenderType attribute to inform the client of the HTML that was ultimately used.

Copy link

github-actions bot commented Jan 30, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   23m 29s ⏱️ +20s
747 tests ±0  745 ✔️ ±0  2 💤 ±0  0 ±0 
752 runs  ±0  750 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit eac4b76. ± Comparison against base commit 1f3544b.

♻️ This comment has been updated with latest results.

@FadhlanR FadhlanR force-pushed the cs-7706-adding-renderType-to-prerendered-search branch from ddc69ec to a1d389a Compare January 30, 2025 14:18
@FadhlanR FadhlanR changed the title (WIP) Adding renderType flag to prerendered search (WIP) Adding renderType flag to prerendered search endpoint Jan 30, 2025
@FadhlanR FadhlanR changed the title (WIP) Adding renderType flag to prerendered search endpoint Adding renderType flag to prerendered search endpoint Jan 30, 2025
@FadhlanR FadhlanR requested a review from a team January 30, 2025 17:11
@FadhlanR FadhlanR marked this pull request as ready for review January 30, 2025 17:12
Copy link
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good for @habdelra to review this when he gets back from vacation too (not a blocker)

@FadhlanR FadhlanR merged commit 005b910 into main Jan 31, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants