Adding renderType flag to prerendered search endpoint #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FadhlanR
force-pushed
the
cs-7706-adding-renderType-to-prerendered-search
branch
from
ddc69ec to
a1d389a
Compare
FadhlanR
changed the title
FadhlanR
changed the title
burieberry
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new parameter called
renderTypeto the prerendered search endpoint. If this parameter is defined, we will return the corresponding HTML; if it is not defined or if the HTML is not found, we will return whatever is available. Additionally, I have added ausedRenderTypeattribute to inform the client of the HTML that was ultimately used.