-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS-7889 task page lhs filter #2068
base: main
Are you sure you want to change the base?
Conversation
Host Test Results 1 files ±0 1 suites ±0 23m 31s ⏱️ + 1m 48s Results for commit 3ce4c9c. ± Comparison against base commit 673efbc. This pull request removes 733 and adds 742 tests. Note that renamed tests count towards both.
This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
this.cardsQuery = getCards(this.getTaskQuery, this.realmHrefs, { | ||
isLive: true, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't getTaskQuery the only one which is changing? I think that is the expectation for the resource pattern. Generally, we shudn't reassign the resource particularly inside of a getter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tintinthong yes it should be only query changing. I have same thought that getCards
API should be reactive when query changes, but currently it is not.
One example I did before was in deal summary page, we do a restartable tasks when the filter changes: #2002. This PR currently use this approach as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is surprising to me
This should fix everything #2088. Depends on core team review and follow-up |
Refer to https://linear.app/cardstack/issue/CS-7889/task-page-lhs-filter-narrow-down-the-task-by-condition
What is changing
Notes
Screenshot
Screen.Recording.2025-01-23.at.10.43.56.PM.mov