Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coarse error trapping #1766

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Coarse error trapping #1766

wants to merge 2 commits into from

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 7, 2024

First draft of an error trapping component that uses the same technique as our pre-render's isolated-render.

  • make our isolated rendering environment do normal re-renders
  • refactor the pre-render to be built on top of error-trap

@ef4
Copy link
Contributor Author

ef4 commented Nov 7, 2024

The first major finding from attempting this is that our existing isolated pre-render doesn't support re-rendering. It's one-and-done.

Copy link

github-actions bot commented Nov 7, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   20m 28s ⏱️ -44s
684 tests +5  681 ✔️ +3  1 💤 ±0  0 ±0  2 🔥 +2 
689 runs  +5  684 ✔️ +1  1 💤 ±0  2 +2  2 🔥 +2 

For more details on these errors, see this check.

Results for commit f27e211. ± Comparison against base commit f70ca43.

♻️ This comment has been updated with latest results.

@ef4
Copy link
Contributor Author

ef4 commented Nov 7, 2024

The next bit of code I need to touch in ember is different between our current version (5.4) and newer releases, so I'm going to do the update first.

@ef4
Copy link
Contributor Author

ef4 commented Nov 7, 2024

The stack is getting deeper. In the process of updating ember I hit the fact that our runtime card compile is still on the old ember-template-imports implementation rather than the new content-tag based implementation. So I'm working on updating that, then ember, then coming back to this pr.

@ef4
Copy link
Contributor Author

ef4 commented Nov 13, 2024

First part of card transpilation toolchain upgrade is landed: #1771. Now it uses the same decorator transpilation that the rest of host uses.

Second part will be replacing @cardstack/ember-template-imports with content-tag. I started with that and hit a snag with fastboot wasm support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant