Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: Update to ember-window-mock v1.0.1 #1453

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

backspace
Copy link
Contributor

This permits the removal of a pnpm peer dependency override from #1431.

@backspace backspace self-assigned this Jul 23, 2024
Without this host had build errors like this:

ERROR in ./components/ai-assistant/panel.ts 12:0-39
Module not found: Error: Default condition should be last one
 @ ./tests/integration/components/ai-assistant-panel-test.ts 14:0-92 1221:32-59 1225:35-62
 @ ./assets/test.js 179:13-95

ERROR in ./components/ai-assistant/toast.ts 11:0-39
Module not found: Error: Default condition should be last one
 @ ./components/operator-mode/submode-layout.ts 22:0-77 292:113-129
 @ ./components/operator-mode/code-submode.ts 28:0-45 862:18-31
 @ ./components/operator-mode/container.ts 21:0-80 184:48-59
 @ ./tests/integration/components/ai-assistant-panel-test.ts 21:0-78 461:22-34 529:22-34 1174:22-34 1205:22-34 1288:22-34 1387:22-34 1947:22-34
 @ ./assets/test.js 179:13-95
Copy link

github-actions bot commented Jul 23, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   15m 17s ⏱️ +15s
648 tests ±0  646 ✔️ ±0  2 💤 ±0  0 ±0 
653 runs  ±0  651 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 32c1547. ± Comparison against base commit 3dd60f9.

♻️ This comment has been updated with latest results.

@backspace backspace changed the title host: Update to ember-window-mock v1 host: Update to ember-window-mock v1.0.1 Jul 24, 2024
@backspace backspace marked this pull request as ready for review July 24, 2024 15:13
@backspace backspace requested a review from a team July 24, 2024 15:13
@backspace backspace merged commit 8074aa9 into main Jul 25, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants