Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/host/firefox-fixes' into firefox…
Browse files Browse the repository at this point in the history
…-ci-and-fixes
  • Loading branch information
backspace committed Jul 12, 2024
2 parents aeeead9 + 831fedc commit dd54824
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 1 addition & 2 deletions packages/host/tests/acceptance/code-submode/editor-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {
setupAcceptanceTestRealm,
visitOperatorMode,
waitForCodeEditor,
waitForSyntaxHighlighting,
type TestContextWithSSE,
type TestContextWithSave,
} from '../../helpers';
Expand Down Expand Up @@ -325,7 +324,7 @@ module('Acceptance | code submode | editor tests', function (hooks) {
// TODO we often timeout waiting for syntax highlighting, so i'm commenting
// out this assertion and creating a ticket to research this: CS-6770

await waitForSyntaxHighlighting('"Pet"', 'rgb(4, 81, 165)');
// await waitForSyntaxHighlighting('"Pet"', 'rgb(4, 81, 165)');
// await percySnapshot(assert);
});

Expand Down
5 changes: 3 additions & 2 deletions packages/host/tests/helpers/index.gts
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,9 @@ export async function waitForSyntaxHighlighting(

await waitUntil(
() =>
finalHighlightedToken?.computedStyleMap()?.get('color')?.toString() ===
color,
window
.getComputedStyle(finalHighlightedToken)
.getPropertyValue('color') === color,
{
timeout: 2000,
timeoutMessage: 'timed out waiting for syntax highlighting',
Expand Down

0 comments on commit dd54824

Please sign in to comment.