Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve errors and remove checks on ncviewjs:-prefixed attributes #39

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

katamartin
Copy link
Member

This PR makes several changes to make rendered errors more applicable to issues that different datasets make encounter. In the process, it also removes checks on ncviewjs:-prefixed attributes, which means that this change is not compatible with what is currently on main in https://github.com/carbonplan/leap-data-catalog/.

  • Improve 2D variable detection (0e37d89)
  • Consolidate general variable checks with cfAxes checks (2a78b17)
    • In order to do this, it was necessary to remove checks against ncviewjs:-prefixed attributes (c206859)
  • Add tests for metadata utility functions

@katamartin katamartin requested a review from andersy005 April 26, 2024 21:31
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:01pm

@katamartin
Copy link
Member Author

Documenting Slack discussion: addressing changes to functions that were moved in this PR in separate issue (#40).

@andersy005
Copy link
Member

In the process, it also removes checks on ncviewjs:-prefixed attributes, which means that this change is not compatible with what is currently on main in carbonplan/leap-data-catalog.

@katamartin
Copy link
Member Author

@andersy005 yeah! I was thinking we might want to iron out all of the remaining issues in carbonplan/leap-data-catalog#40 before merging these two PRs, but I could be convinced otherwise.

@katamartin katamartin merged commit 43ebd69 into main Apr 30, 2024
8 checks passed
@katamartin katamartin deleted the katamartin/improve-errors branch April 30, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants