-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve errors and remove checks on ncviewjs:
-prefixed attributes
#39
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Documenting Slack discussion: addressing changes to functions that were moved in this PR in separate issue (#40). |
|
@andersy005 yeah! I was thinking we might want to iron out all of the remaining issues in carbonplan/leap-data-catalog#40 before merging these two PRs, but I could be convinced otherwise. |
This PR makes several changes to make rendered errors more applicable to issues that different datasets make encounter. In the process, it also removes checks on
ncviewjs:
-prefixed attributes, which means that this change is not compatible with what is currently onmain
in https://github.com/carbonplan/leap-data-catalog/.ncviewjs:
-prefixed attributes (c206859)