Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert framer motion version #6861

Merged

Conversation

matthewgallo
Copy link
Member

I noticed that framer-motion snuck past us in the dev dependency PR. We should merge this before our code freeze to prevent it from reaching an rc publish.

What did you change?

packages/ibm-products/package.json
yarn.lock

@matthewgallo matthewgallo requested a review from a team as a code owner February 7, 2025 15:36
@matthewgallo matthewgallo requested review from devadula-nandan and anamikaanu96 and removed request for a team February 7, 2025 15:36
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit d3fd22f
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67a63974c6d99e0008aee1a3
😎 Deploy Preview https://deploy-preview-6861--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit d3fd22f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67a639748e4d520008cfbf5d
😎 Deploy Preview https://deploy-preview-6861--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

elycheea
elycheea previously approved these changes Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.49%. Comparing base (c85b197) to head (d3fd22f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6861      +/-   ##
==========================================
- Coverage   81.51%   81.49%   -0.02%     
==========================================
  Files         399      399              
  Lines       12991    12978      -13     
  Branches     4275     4270       -5     
==========================================
- Hits        10590    10577      -13     
  Misses       2401     2401              
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@elycheea elycheea added this pull request to the merge queue Feb 7, 2025
Merged via the queue into carbon-design-system:main with commit a9a4285 Feb 7, 2025
31 checks passed
@matthewgallo matthewgallo deleted the framer-motion-revert-version branch February 7, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants