fix(useravatar): variable change #6856
Conversation
anamikaanu96
requested review from
davidmenendez and
sangeethababu9223
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6856 +/- ##
=======================================
Coverage 81.31% 81.31%
=======================================
Files 397 399 +2
Lines 12959 12965 +6
Branches 4261 4262 +1
=======================================
+ Hits 10537 10543 +6
Misses 2422 2422
|
| @@ -83,8 +83,8 @@ $sizes: ( | |||
| @mixin setDarkBg($order, $color) { | |||
| .#{$carbon-prefix}--g90 .#{$block-class}--#{$order}, | |||
| .#{$carbon-prefix}--g100 .#{$block-class}--#{$order}, | |||
| [storybook-carbon-theme='g90'] .#{$block-class}--#{$order}, | |||
| [storybook-carbon-theme='g100'] .#{$block-class}--#{$order} { | |||
| [data-carbon-theme='g90'] .#{$block-class}--#{$order}, | |||
There was a problem hiding this comment.
These styles will be applied to both versions of the UserAvatar component (react and web component). We also should update our web component storybook to use the data-carbon-theme as the attribute controlling the theming.
The two files to update for that are
packages/ibm-products-web-components/.storybook/preview.ts
and
packages/ibm-products-web-components/.storybook/container.scss
There was a problem hiding this comment.
didn't think of this. good call!
There was a problem hiding this comment.
hey @matthewgallo , @davidmenendez Thanks for reviewing! I noticed that some other files are also using storybook-carbon-theme, so I updated those files too.
config/storybook-addon-carbon-theme/README.md
config/storybook-addon-carbon-theme/src/decorators/withCarbonTheme.js
packages/core/.storybook/index.scss -> only comment change
2e6fc2b
Closes #6854
I noticed this while working on user avatar web components.
The root cause of issue is that the storybook theme variable is changed from storybook-carbon-theme to data-carbon-theme.
With wrapper it is working fine.
What did you change? packages/ibm-products-styles/src/components/UserAvatar/_user-avatar.scss
How did you test and verify your work? storybook