Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditionBuilder): add support for custom operators in ConditionBuilder #6841

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

amal-k-joy
Copy link
Contributor

@amal-k-joy amal-k-joy commented Feb 4, 2025

Closes #6422

This gives user to pass a custom list of operators if they want to override default operators for any inout type.
When the input types is option, they can pass multiSelect true to enable multiselect drop down

What did you change?

Corrected types
Add tests
Support a custom operator configuration

{
properties: [
{
id: 'propertyId',
label: 'property name',
type: 'option', // 'text' | 'textarea' | 'number' | 'date' | 'option' | 'time' | 'custom'
config: {
operators:customOperators,
...other configs
}
}
]
}

How did you test and verify your work?

local storybook

@amal-k-joy amal-k-joy requested a review from a team as a code owner February 4, 2025 10:34
@amal-k-joy amal-k-joy requested review from davidmenendez and sangeethababu9223 and removed request for a team February 4, 2025 10:34
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 9ebc0e1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67a5c29395e3c80008b9b3ad
😎 Deploy Preview https://deploy-preview-6841--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 9ebc0e1
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67a5c294be50aa00083bf9b7
😎 Deploy Preview https://deploy-preview-6841--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy changed the title Condition builder6422 feat(conditionBuilder): Insufficient support for custom operators in ConditionBuilder Feb 4, 2025
@amal-k-joy amal-k-joy changed the title feat(conditionBuilder): Insufficient support for custom operators in ConditionBuilder feat(conditionBuilder): add support for custom operators in ConditionBuilder Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (2ac32d0) to head (9ebc0e1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6841      +/-   ##
==========================================
+ Coverage   81.36%   81.45%   +0.09%     
==========================================
  Files         399      399              
  Lines       12965    12987      +22     
  Branches     4262     4271       +9     
==========================================
+ Hits        10549    10579      +30     
+ Misses       2416     2408       -8     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@amal-k-joy amal-k-joy requested a review from makafsal February 5, 2025 04:17
davidmenendez
davidmenendez previously approved these changes Feb 5, 2025
makafsal
makafsal previously approved these changes Feb 7, 2025
@amal-k-joy amal-k-joy dismissed stale reviews from makafsal and davidmenendez via c83a56a February 7, 2025 08:20
@makafsal makafsal self-requested a review February 7, 2025 08:24
Merged via the queue into carbon-design-system:main with commit 9a603ed Feb 7, 2025
31 checks passed
@amal-k-joy amal-k-joy deleted the conditionBuilder6422 branch February 7, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Insufficient support for custom operators in ConditionBuilder
4 participants