Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task(Menu): React|WC Parity sub issue #6993

Open
amal-k-joy opened this issue Feb 27, 2025 · 1 comment
Open

Task(Menu): React|WC Parity sub issue #6993

amal-k-joy opened this issue Feb 27, 2025 · 1 comment
Assignees
@amal-k-joy

Comments

@amal-k-joy
Copy link
Contributor

amal-k-joy commented Feb 27, 2025 •
edited
Loading

Cherry pick the PR over from the old repo
Update/remove mode, see carbon-design-system/carbon#18153

Pending:
We have cds menu as parent and menu items as children inside a slot. We need to apply a particular style when none of the items has rendered with an icon. If any of the items is rendered with icon, we need to reserve a blank space for all menu items in that parent menu, otherwise not. Styling from parent does not work as in react.
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Feb 27, 2025
@amal-k-joy amal-k-joy changed the title Bug(Menu): extra space when the menu doesn't have any menu item with an icon Bug(Menu): React|WC Parity sub issue Feb 27, 2025
@amal-k-joy amal-k-joy self-assigned this Feb 27, 2025
@amal-k-joy amal-k-joy changed the title Bug(Menu): React|WC Parity sub issue Task(Menu): React|WC Parity sub issue Feb 27, 2025
@amal-k-joy amal-k-joy moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Feb 27, 2025
@amal-k-joy amal-k-joy moved this from Backlog 🌋 to Done 🚀 in Carbon for IBM Products Feb 27, 2025
@amal-k-joy amal-k-joy closed this as completed by moving to Done 🚀 in Carbon for IBM Products Feb 27, 2025
@amal-k-joy amal-k-joy moved this from Done 🚀 to Needs review 👋 in Carbon for IBM Products Feb 27, 2025
@amal-k-joy
Copy link
Contributor Author

ref
carbon-design-system/carbon#18703
carbon-design-system/carbon#18612

@amal-k-joy amal-k-joy mentioned this issue Feb 27, 2025
Open
4 tasks
@amal-k-joy amal-k-joy reopened this Feb 27, 2025
@github-project-automation github-project-automation bot moved this from Needs review 👋 to Needs triage 🧐 in Carbon for IBM Products Feb 27, 2025
@amal-k-joy amal-k-joy moved this to Needs review 👋 in Carbon for IBM Products Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amal-k-joy amal-k-joy

Labels
None yet
Projects
Carbon for IBM Products
Status: Needs review 👋
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amal-k-joy