Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(floating-ui): revert back to allow for react 16 #18726

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

Closes #18717

dependency break with upgrading floating ui

Changelog

Changed

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit fa26353
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67c0b84a54e75a0008950aee
😎 Deploy Preview https://deploy-preview-18726--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit fa26353
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67c0b84ace54a60008b9efe4
😎 Deploy Preview https://deploy-preview-18726--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit fa26353
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67c0b84a7342e80008486d96
😎 Deploy Preview https://deploy-preview-18726--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 23fb326
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67c0b8c9814998000851aa7f
😎 Deploy Preview https://deploy-preview-18726--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 23fb326
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67c0b8c9a4f4500008eadf37
😎 Deploy Preview https://deploy-preview-18726--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 23fb326
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67c0b8c954e7fb0008eef1d1
😎 Deploy Preview https://deploy-preview-18726--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (1d57a3a) to head (23fb326).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18726   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         408      408           
  Lines       14645    14645           
  Branches     4791     4821   +30     
=======================================
  Hits        12352    12352           
  Misses       2131     2131           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dependency break with @floating-ui/react
1 participant