refactor(FloatingMenu): rewrite in typescript #18722
Open
+542
−539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18720
Rewrote
FloatingMenu
in TypeScript.Changelog
Changed
FloatingMenu
in TypeScript.wrapFocus
util andOverflowMenu
component.Testing / Reviewing
yarn test packages/react/src/components/OverflowMenu
I left a
TODO
in the code. Curious to hear others' thoughts.I didn't see a reason to memoize
handleMenuRef
or put it in auseCallback
. If someone finds one, this code should work.