fix(Menu): fix extra gap issue when the menu doesnt contain any item with icon #18718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolved changes
…nto menuWC_parity
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18718 +/- ##
==========================================
- Coverage 84.97% 84.34% -0.64%
==========================================
Files 408 408
Lines 14542 14645 +103
Branches 4764 4791 +27
==========================================
- Hits 12357 12352 -5
- Misses 2024 2131 +107
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes #18338
We have cds menu as parent and menu items as children inside a slot. We need to apply a particular style when none of the items has rendered with an icon. If any of the items is rendered with icon, we need to reserve a blank space for all menu items in that parent menu, otherwise not. Styling from parent does not work as in react.
Here I am dispatching an event from menu item when there is an icon and listened by parent menu and class is added to the parent menu accordingly.
The child items style is then handled using css variables.
Testing / Reviewing
Local storybook