fix(combobox): onInputChange calls #18713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove useEffect calling onInputChange on initial render * Leverage useCombobox's onStateChange to call onInputChange * Unit tests
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18713 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 408 408
Lines 14645 14646 +1
Branches 4791 4824 +33
=======================================
+ Hits 12352 12353 +1
Misses 2131 2131
Partials 162 162 ☔ View full report in Codecov by Sentry. |
|
Hey @Neues, setting up a test story would help us to test the fix. Could you do that please?? |
|
No problem @Gururajj77, comment updated with instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16969
Fix defect in ComboBox causing onInputChange to be called on initial render.
Changelog
Changed
onInputChangeon initial renderonStateChangeto callonInputChange. Note that they provide onInputValueChange. They advise to use this only when inputValue is controlled, and in our case, we only are providing the callback. Therefore I think it is ok to handle this inonStateChange.Testing/Reviewing
Observing Defect:
on
mainbranch, addonInputChangeprop todefaultComboBox inComoboBox.stories.jsie, line 192
run storybook
http://localhost:3001/?path=/story/components-combobox--default
confirm that log shows up in console on initial render
Observing fix:
repeat steps above and confirm onInputChange is not called on initial render, and is only called on input change