Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite internal keyboard utils in typescript #18707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

Closes #18705

Rewrote the internal keyboard utilities in TypeScript.

Changelog

Changed

  • Rewrote the internal keyboard utilities in TypeScript.
  • Improved types in components that used the internal keyboard utilities.

Testing / Reviewing

yarn test packages/react

Reference commit: adamalston@f12a0e3

@adamalston adamalston requested review from a team as code owners February 26, 2025 13:48
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 070fc20
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67bf1bc8862a7f00088b6e5b
😎 Deploy Preview https://deploy-preview-18707--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 070fc20
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67bf1bc889f4d1000878d1a0
😎 Deploy Preview https://deploy-preview-18707--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 070fc20
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67bf1bc8b032f00008d85c01
😎 Deploy Preview https://deploy-preview-18707--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (3cf17ef) to head (070fc20).

Files with missing lines Patch % Lines
...react/src/components/FileUploader/FileUploader.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18707      +/-   ##
==========================================
- Coverage   84.34%   84.34%   -0.01%     
==========================================
  Files         408      405       -3     
  Lines       14645    14598      -47     
  Branches     4821     4752      -69     
==========================================
- Hits        12352    12312      -40     
+ Misses       2132     2127       -5     
+ Partials      161      159       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite internal keyboard utils in TypeScript
1 participant