Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu : deprecate props.mode / always support full capabilities + icons #18703

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

amal-k-joy
Copy link
Contributor

Contributes #18338

Adopt changes from jans PR for deprecating mode

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@amal-k-joy amal-k-joy marked this pull request as draft February 26, 2025 11:50
@amal-k-joy amal-k-joy changed the title Menu wc parity Menu : deprecate props.mode / always support full capabilities + icons Feb 26, 2025
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a5ba6ac
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67bf000b8c3b0c000834d162
😎 Deploy Preview https://deploy-preview-18703--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a5ba6ac
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67bf000b28c1900008ab0825
😎 Deploy Preview https://deploy-preview-18703--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a5ba6ac
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67bf000b7eebc90008963bdd
😎 Deploy Preview https://deploy-preview-18703--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (b67877b) to head (a5ba6ac).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18703      +/-   ##
==========================================
- Coverage   84.97%   84.34%   -0.64%     
==========================================
  Files         408      408              
  Lines       14542    14645     +103     
  Branches     4764     4771       +7     
==========================================
- Hits        12357    12352       -5     
- Misses       2024     2132     +108     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants