-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu : deprecate props.mode / always support full capabilities + icons #18703
base: main
Are you sure you want to change the base?
Conversation
resolved changes
…nto menuWC_parity
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18703 +/- ##
==========================================
- Coverage 84.97% 84.34% -0.64%
==========================================
Files 408 408
Lines 14542 14645 +103
Branches 4764 4771 +7
==========================================
- Hits 12357 12352 -5
- Misses 2024 2132 +108
Partials 161 161 ☔ View full report in Codecov by Sentry. |
Contributes #18338
Adopt changes from jans PR for deprecating mode
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}