-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: normalize renderIcon
types
#18683
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18683 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 409 409
Lines 14651 14651
Branches 4824 4774 -50
=======================================
Hits 12358 12358
- Misses 2131 2132 +1
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
I think all JSDoc comments for |
Hey
Hey @adamalston , I agree with your suggestion. Can you make change to the comments, and we can see what we can do with that. |
I have updated all JSDoc comments. There are a few different ways I envision things could go now:
Obviously, I'll do whatever you guys want. My goal here was to try and introduce some consistency. |
Closes #16735
Normalized
renderIcon
types.Changelog
Changed
renderIcon
types.Testing / Reviewing
Paste the code from the issue at the bottom of Tabs.tsx and check for errors.