Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update button docs and stories to follow guidelines #18674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

@adamalston adamalston commented Feb 23, 2025

Closes #18673

Updated the Button documentation and stories to follow the guidelines.

Changelog

Changed

  • Updated the Button documentation and stories to follow the guidelines.
  • Updated the documentation to be consistent between @carbon/react and @carbon/web-components.

Testing / Reviewing

cd packages/react
yarn storybook

Copy link

netlify bot commented Feb 23, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 4d11742
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67bb8a916faf310008bfe591
😎 Deploy Preview https://deploy-preview-18674--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 23, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4d11742
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67bb8a90f7bb000008920ab9
😎 Deploy Preview https://deploy-preview-18674--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 23, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d11742
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67bb8a905f9e34000879213b
😎 Deploy Preview https://deploy-preview-18674--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (b67877b) to head (4d11742).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18674   +/-   ##
=======================================
  Coverage   84.97%   84.97%           
=======================================
  Files         408      408           
  Lines       14542    14542           
  Branches     4764     4764           
=======================================
  Hits        12357    12357           
  Misses       2024     2024           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamalston adamalston marked this pull request as ready for review February 23, 2025 21:24
@adamalston adamalston requested review from a team as code owners February 23, 2025 21:24
@adamalston
Copy link
Contributor Author

I don't have permissions to approve the Percy changes. I think they look right though with the updated wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update button guidance to follow guidelines
3 participants