-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NumberInput): fix floating-point precision issues #18670
base: main
Are you sure you want to change the base?
fix(NumberInput): fix floating-point precision issues #18670
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18670 +/- ##
=======================================
Coverage 84.34% 84.35%
=======================================
Files 409 409
Lines 14651 14653 +2
Branches 4824 4773 -51
=======================================
+ Hits 12358 12360 +2
- Misses 2131 2132 +1
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
Mend appears to be consistently inconsistent, just like in GitHub Enterprise. |
Closes #18591
Fixed floating-point precision issues in the
NumberInput
.Changelog
New
NumberInput
utils.Changed
NumberInput
.Testing / Reviewing
yarn test packages/react/src/components/NumberInput