Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NumberInput): fix floating-point precision issues #18670

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

Closes #18591

Fixed floating-point precision issues in the NumberInput.

Changelog

New

  • Added types for NumberInput utils.

Changed

  • Fixed floating-point precision issues in the NumberInput.

Testing / Reviewing

yarn test packages/react/src/components/NumberInput

Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 00ce27a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67bd3b7713ade80008fbe880
😎 Deploy Preview https://deploy-preview-18670--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 00ce27a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67bd3b77d0ee1d0008513a1a
😎 Deploy Preview https://deploy-preview-18670--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 00ce27a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67bd3b77876b3a0009f9906e
😎 Deploy Preview https://deploy-preview-18670--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.35%. Comparing base (faf6498) to head (00ce27a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...s/react/src/components/NumberInput/NumberInput.tsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18670   +/-   ##
=======================================
  Coverage   84.34%   84.35%           
=======================================
  Files         409      409           
  Lines       14651    14653    +2     
  Branches     4824     4773   -51     
=======================================
+ Hits        12358    12360    +2     
- Misses       2131     2132    +1     
+ Partials      162      161    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamalston
Copy link
Contributor Author

adamalston commented Feb 22, 2025

Mend appears to be consistently inconsistent, just like in GitHub Enterprise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NumberInput: Inconsistent decimal precision handling
2 participants