-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breadcrumb): sm size #18665
base: main
Are you sure you want to change the base?
feat(breadcrumb): sm size #18665
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18665 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 408 408
Lines 14645 14645
Branches 4791 4791
=======================================
Hits 12352 12352
Misses 2131 2131
Partials 162 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to work on this and it is looking really great!
Here are some things I noticed:
Deploy preview for web-components:
- Overflow - open state:
- Currently if you open the overflow the drop down is missing a caret and does not look like the drop down component
- The hover state is missing the tooltip of "Options"

- Overflow icon color
- Currently the icon color is $text-primary and should be at #link-primary

- Hover tooltip placement
- Currently the hover tooltip placement is top aligned to the overflow icon, it should be bottom aligned under the overflow icon
FYI @laurenmrice
@sunny-babbar thanks for the review! just pushed some fixes! React should be updated at the next deploy preview. For web components the caret/hover issue should be fixed as part of the parity work here: #18414. |
@ariellalgilmore Great thank you for the update on bug fixes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool that you were able to include react & wc updates here in one PR 🔥
packages/react/src/components/Breadcrumb/__tests__/Breadcrumb-test.js
Outdated
Show resolved
Hide resolved
.#{$prefix}--breadcrumb--sm .#{$prefix}--breadcrumb-item { | ||
margin-inline-end: $spacing-02; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the other size-related styling is fine as-is but just as a heads up we'll eventually want this component to take advantage of the contextual layout tokens, #13923
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a react VRT test for the small breadcrumb? We should be able to pass controls/args to the snapshot helper function(s) to set size
to sm
…test.js Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Hey @ariellalgilmore this is looking really good, I also saw a small bug here: Breadcrumb With Overflow Menu story
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke with Ari, and we will make a separate issue for the overflow bugs because it is unrelated to the small breadcrumb changes. Looks good to me!
Closes #18356
worked with @Gururajj77 !
Add new prop size to breadcrumb
Changelog
New
Changed
Testing / Reviewing
Go to breadcrumb stories for both react and wc. Change the control size to sm and compare to specs