-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Dropdown and MultiSelect to handle interactive labels #18643
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18643 +/- ##
=======================================
Coverage 84.97% 84.97%
=======================================
Files 408 408
Lines 14543 14545 +2
Branches 4765 4771 +6
=======================================
+ Hits 12358 12360 +2
Misses 2023 2023
Partials 162 162 ☔ View full report in Codecov by Sentry. |
ecb134d
to
106c5f5
Compare
106c5f5
to
508a733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #16987
Updated
Dropdown
andMultiSelect
to handle interactive labels.Changelog
Changed
Dropdown
andMultiSelect
to handle interactive labels.Testing / Reviewing
yarn test packages/react/src/components/Dropdown packages/react/src/components/MultiSelect
I tried to write a test for these changes. I couldn't get it to pass. I think it has something to do with the changing visibility of the popover and its visibility from the test's perspective. Curious to hear if anyone has suggestions to test these changes. Alternatively, I created Storybook entries.