-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: codemode to enable-v12-structured-list-visible-icons #18615
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18615 +/- ##
==========================================
- Coverage 84.97% 84.26% -0.72%
==========================================
Files 408 408
Lines 14543 14659 +116
Branches 4765 4795 +30
==========================================
- Hits 12358 12352 -6
- Misses 2023 2143 +120
- Partials 162 164 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After long discussion about this PR with @2nikhiltom I got my confusions cleared.
Closes #18351
codemode updates selectable StructuredList components with new v12 selection structuredList
Added
messageConfig
option to display post run message if migration providesIt does the following
Replaces checkmark icons with radio buttons (by adding
selection
prop to all StructuredListRow)Identifies StructuredListWrapper components with the selection prop and adds
selection
prop to all childrenStructuredListRow
Checks if the last StructuredListRow has checkmark icon and removes the cell
Changelog
New
Added enable-v12-structured-list-visible-icons codemode
Updated test fixtures for the same
Testing / Reviewing
npx @carbon/upgrade migrate enable-v12-structured-list-visible-icons --write
cd packages/react
yarn storybook
and verify the changes made after running the codemode makes the deafult structuredlist--selection look similar to its feature-flag version