-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Menu): integration of menu web component to carbon repo #18612
base: main
Are you sure you want to change the base?
feat(Menu): integration of menu web component to carbon repo #18612
Conversation
resolved changes
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18612 +/- ##
==========================================
+ Coverage 84.02% 84.97% +0.95%
==========================================
Files 408 408
Lines 14494 14542 +48
Branches 4726 4764 +38
==========================================
+ Hits 12178 12357 +179
+ Misses 2149 2023 -126
+ Partials 167 162 -5 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me! I did find a couple functional mismatches though:
- Does not open submenu when pressing spacebar. Here I'm pressing the spacebar twice on each of them
2025-02-27.at.13.48.25-Components.Menu.-.Default.Storybook-Google.Chrome.mp4
- same thing as above w/ the spacebar, but with selection
2025-02-27.at.13.56.16-Components.Menu.-.Default.Storybook-Google.Chrome.mp4
- Submenu's do open when pressing enter, but focus does not move to the submenu
2025-02-27.at.13.53.01-Components.Menu.-.Default.Storybook-Google.Chrome.mp4
.#{$prefix}--menu { | ||
@include component-reset; | ||
@include box-shadow; | ||
|
||
position: fixed; | ||
z-index: z('modal'); | ||
padding: $spacing-02 0; | ||
background-color: $layer; | ||
max-inline-size: 18rem; | ||
min-inline-size: 10rem; | ||
opacity: 0; | ||
overflow-y: auto; | ||
visibility: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a duplication of these styles required?
carbon/packages/styles/scss/components/menu/_menu.scss
Lines 27 to 40 in d975d04
.#{$prefix}--menu { | |
@include component-reset.reset; | |
@include box-shadow; | |
position: fixed; | |
z-index: z('modal'); | |
padding: $spacing-02 0; | |
background-color: $layer; | |
max-inline-size: 18rem; | |
min-inline-size: 10rem; | |
opacity: 0; | |
overflow-y: auto; | |
visibility: hidden; | |
} |
Contributes #18338 ,#17917
This PR is the cherry pick of Sangeethas PR from dotcom repo
Changelog
New
Menu
component from dotCom to the folder carbon-webcomponents as part of cherry pickpackages/carbon-webcomponents
folder topackages/webcomponents
folderTesting / Reviewing
The basic functionality is verified in local storybook