feat(ui): Add secret management UI #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
commented
Feb 6, 2025
Comment on lines
-52
to
+54
| selected={job.version_id} | ||
| selected={job.version_id.toString()} |
There was a problem hiding this comment.
This change was made to prevent some error that's being thrown about the argument selected containing an integer instead of a string.
deadlycoconuts
commented
Feb 6, 2025
| @@ -125,7 +125,6 @@ export const EnvironmentVariablesForm = ({ variables, onChange }) => { | |||
| className="EnvVariables" | |||
| columns={columns} | |||
| items={items} | |||
| hasActions={true} | |||
There was a problem hiding this comment.
This change is to prevent some errors that appear due to this deprecated prop.
deadlycoconuts
commented
Feb 6, 2025
|
|
||
| require("../../../../assets/scss/Secrets.scss"); | ||
|
|
||
| export const SecretsForm = ({ variables, onChange }) => { |
There was a problem hiding this comment.
This component is more or less a simplified copy of the EnvironmentVariablesForm component.
deadlycoconuts
requested review from
mbruner,
shydefoo,
bthari and
vinoth-gojek
|
Thanks for the detailed description in the MR @deadlycoconuts . Overall lgtm In the MR, there is a useMerlinApi call which I assume is responsible for storing the secret in backend. But I don't quite get how this endpoint is triggered. Could you share how the secret gets saved when batch or deployment is submitted? |
vinoth-gojek
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on the new feature allowing users to configure MLP secrets in their model services/batch jobs as introduced in PR #625, this PR introduces UI changes to complement that feature, allowing users to configure secrets for model services and batch jobs, as well as to view them in the details page view.
Model Services
Deployment Page
Details Page
Batch Jobs
Submission Page
Details Page
Note that the schema validation unfortunately only exists for model service deployments and not batch jobs, and as such this PR does not add additional new validation checks for the
secretsfield for batch jobs triggered via the UI.Some of the changes to the column widths/proportions were done to improve consistency in the component sizes throughout the UI.
Additional Change
This PR also includes a tiny fix to the API server to ensure that k8s secrets for each Merlin transformer is only created when the transformer is actually enabled (as opposed to when the transformer config exists).
Modifications
api/cluster/controller.go- Fix for the API server to not create transformer secrets unnecessarilyui/src/components/SecretsConfigTable.js- New component to display secrets in the details viewui/src/pages/job/form/components/SecretsForm.js- New form for users to configure secrets for batch jobsui/src/pages/job/form/context.js- Addition of a new context setter for the secrets fieldui/src/pages/version/components/forms/components/SecretsPanel.js- New form for users to configure secrets for model servicesui/src/pages/version/components/forms/validation/schema.js- Addition of validation schema for secrets used in model servicesTests
Checklist
Release Notes