Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the module compatible with composer #9

Open
capynet opened this issue Oct 24, 2017 · 1 comment
Open

Make the module compatible with composer #9

capynet opened this issue Oct 24, 2017 · 1 comment
Assignees

Comments

@capynet
Copy link
Owner

capynet commented Oct 24, 2017

  • The module needs to be able to be added as dependency on a project via composer require drupal/OURMODULE
  • The module itself needs a composer.json with "paypal/rest-api-sdk-php" as dependency.
@capynet capynet added this to the MVP milestone Oct 25, 2017
@fran fran self-assigned this Oct 25, 2017
@capynet capynet removed this from the MVP milestone Oct 29, 2017
@fran
Copy link
Collaborator

fran commented Jul 23, 2018

I think the problem is fixed since Drupal use wikimedia/composer-merge-plugin. Adding this code to composer.json in the project the library will be added automatically.

"merge-plugin": {
            "include": [
                "core/composer.json",
                **"modules/contrib/DrupalPayPalRecurrringPayment/paypal_sdk/composer.json"**
            ],
            "recurse": true,
            "replace": false,
            "merge-extra": false
        },

We should only update the README.md file with a note to add the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants