From 2707a4c5a6cf06829265d4242b550b2b398e7468 Mon Sep 17 00:00:00 2001
From: captainurist <73941350+captainurist@users.noreply.github.com>
Date: Tue, 19 Sep 2023 18:10:32 +0800
Subject: [PATCH] TODO added

---
 CMakeLists.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4a365c9b4263..68f71207a062 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -23,7 +23,10 @@ if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "Release")
     endif()
 endif()
 if (BUILD_PLATFORM STREQUAL "linux" AND BUILD_ARCHITECTURE STREQUAL "x86")
-    # Prebuilt ffmpeg on x86 linux is built with --enable-asm, and lld chokes when trying to link with it.
+    # TODO(captainurist): Prebuilt ffmpeg on x86 linux is built with --enable-asm, and ffmpeg x86 asm code doesn't
+    # support position-independent linking. And it looks like lld tries to link position-independent code by default,
+    # and chokes on it. On the other hand, gnu ld works like a charm. Do we need to just pass proper link options for
+    # it to work? For now, we just disable lld.
     set(OE_USE_LD_LLD_DEFAULT OFF)
 else()
     set(OE_USE_LD_LLD_DEFAULT ON)