Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the documentation related to connectivity service #1655

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chaithrashreey
Copy link

@amitsahu01 Have updated the doc as requested.Please review the changes

Copy link

@shubho5 shubho5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- transparent-proxy
- istio

You can do that using the `kubectl` CLI:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to give the users one way right here. If you think this can be outdated quickly, we can remove it again. My impression was, that this would be rather stable.
Pls, overall check if this is done properly if one follows my description. I couldn't test it myself. I just used the linked docs to come up with this.

Comment on lines +483 to +489
```yaml [editor]
spec:
modules:
- name: connectivity-proxy
- name: transparent-proxy
- name: istio
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which file is edited here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And is this correct as I've done it here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitsahu01 Could you please check these updated changes and confirm.

@shubho5 shubho5 requested a review from amitsahu01 February 21, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants